Fix scanline calculation for FFT used by ATMS remapping #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 28, 2024 18:32
(seconds is the default)
rmclaren
reviewed
Sep 30, 2024
core/src/bufr/BufrReader/Exports/Variables/DatetimeVariable.cpp
Outdated
Show resolved
Hide resolved
core/src/bufr/BufrReader/Exports/Variables/DatetimeVariable.cpp
Outdated
Show resolved
Hide resolved
core/src/bufr/BufrReader/Exports/Variables/DatetimeVariable.cpp
Outdated
Show resolved
Hide resolved
core/src/bufr/BufrReader/Exports/Variables/DatetimeVariable.cpp
Outdated
Show resolved
Hide resolved
core/src/bufr/BufrReader/Exports/Variables/DatetimeVariable.cpp
Outdated
Show resolved
Hide resolved
core/src/bufr/BufrReader/Exports/Variables/RemappedBrightnessTemperatureVariable.cpp
Show resolved
Hide resolved
| size_t time_index = 0; | ||
| // Check each set for missing numbers and modify times accordingly | ||
| std::vector<std::tuple<int, int, std::vector<int>, std::vector<int>, int64_t, int64_t>> results; | ||
| std::vector<std::tuple<int, int, std::vector<int>, std::vector<int>, int64_t, int64_t>> results_missing; |
There was a problem hiding this comment.
General: stick to C++ style (camel case).. missingResults instead of results_missing
| } | ||
|
|
||
| if (missing.empty()) { | ||
| results.emplace_back(i + 1, slnm_val, fovn_set, missing, first_time, adjusted_first_time); |
| if (missing.empty()) { | ||
| results.emplace_back(i + 1, slnm_val, fovn_set, missing, first_time, adjusted_first_time); | ||
| } else { | ||
| results_missing.emplace_back(i + 1, slnm_val, fovn_set, missing, first_time, adjusted_first_time); |
Comment on lines
101
to
+104
| std::vector<int64_t> obstime; | ||
| std::vector<int64_t> obstime2; | ||
| obstime = std::dynamic_pointer_cast<DataObject<int64_t>>(datetimeObj)->getRawData(); | ||
| obstime2 = std::dynamic_pointer_cast<DataObject<int64_t>>(datetimeObj)->getRawData(); |
There was a problem hiding this comment.
Why need 2 copies of this?
added 4 commits
September 30, 2024 17:57
|
@rmclaren Thanks for reviewing the code. |
|
@emilyhcliu Thanks for the changes to the DatetimeVariable :) Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATMS remapping code does not work correctly for data from DB (ATMSDB) and RARS (ESATMS) - data becomes missing (grey).
Examples: ESATMS and ATMSDB from N20 Channel 2
Sources of issues identified:
This PR provides the code modifications to resolve the issues listed above.
Here are the results from the corrected code:
