Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3SRCE refactor [draft] #1123

Draft
wants to merge 108 commits into
base: develop
Choose a base branch
from

Commits on May 16, 2023

  1. Configuration menu
    Copy the full SHA
    416f3ce View commit details
    Browse the repository at this point in the history
  2. Cleaned up pre-processor directives in w3srcemd.

    Some code moved around to group together more logically.
    ukmo-ccbunney committed May 16, 2023
    Configuration menu
    Copy the full SHA
    124d93a View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Small update

    ukmo-ccbunney committed May 17, 2023
    Configuration menu
    Copy the full SHA
    cc7e3e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b597ca7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4fbec92 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Configuration menu
    Copy the full SHA
    137e461 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Configuration menu
    Copy the full SHA
    182a943 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8c8c647 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    43249d2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2a57e68 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Remove some rogue CPP directives that were causing havok.

    Wasted most of a day finding them. :(
    ukmo-ccbunney committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    21526c1 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. First set of refactors.

    NOT COMPLETE! CURRENTLY EXITS AFTER FIRST W3SPR4 call
    Made change to allow first W3SPR4 call (when IT=0) to run using all
    arrays:
      - Updates some local variables with CHUNKSIZE dimension.
      - Some input parameters to W3SRCE now have extra NSEA[L[M]] dimension
      - Some chunk element loops (CSEA) added to blocks of code
      - W3SRCE only called once, rather than in seapoint loop
    ukmo-ccbunney committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    120703b View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Refactored variables related to W3SINx routines (NOT YET COMPLETE)

    Chunk dimensions added to VSIN, VDIN and associated variables
    Explicit loop added around calls to W3SINx routines in integration loop
    ukmo-ccbunney committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    60539c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Configuration menu
    Copy the full SHA
    a823b0f View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Configuration menu
    Copy the full SHA
    640af4d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f64246 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Initialised VS/VD correctly, removed some debug.

    Changes are currently B4B with develop (ST4 compile)
    ukmo-ccbunney committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    90c3bf3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c65c996 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Fixed stress outputs:

      - variables were being zeroed in chunk loop
      - claculations where being skipped as SRC_MASK was all true
    Note: Had to recalculate the source mask after integration loop; I need
    to find a better way of doing this.
    ukmo-ccbunney committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    26b0db1 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Correct zeroing of some variables.

    Commented out some unusued vars
    ukmo-ccbunney committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    2957922 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a2e4980 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    846ac5a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4704338 View commit details
    Browse the repository at this point in the history
  5. Fixed LOADS of incorrectly index *_CHUNK variables (became evident …

    …after non-b4b results with non-homeogenous depth).
    
    Also updated PHICE.
    ukmo-ccbunney committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    d743e15 View commit details
    Browse the repository at this point in the history
  6. COEF variable updated

    ukmo-ccbunney committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    4016ce1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    183ce57 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Fixed some typos

    ukmo-ccbunney committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    259d4c3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    909627c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b9ea92b View commit details
    Browse the repository at this point in the history
  4. Updated relection (W3_REF1) code:

      - Required deprecation of REFLEC and REFLED locals in w3srce
      - Calculation of `REFLEC(4) * BERG` moved into w3srce
      - Needs #ifdefs in call to w3srce as REFLC and REFLD are not allocated
    	if W3_REF1 not set
      - Had to make IX and IY chunk arrays in w3srce
    ukmo-ccbunney committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    66189b7 View commit details
    Browse the repository at this point in the history
  5. Updated D50 and PSIC variables:

      - Local scalars no longer used in w3wave
      - Requires #ifdef in W3SRCE call signature.
    ukmo-ccbunney committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    92fec6f View commit details
    Browse the repository at this point in the history
  6. Made VSIO, VDIO and SHAVEIO optional in w3srce subroutine call.

    They are only used for PDLIB implicit source calls; avoids unneccesary
    array allocation for direct souce calls.
    ukmo-ccbunney committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    cb48fb9 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Removed unused arguments in w3str1 call. Also added check for zero

    energy in spectrum in w3str1
    ukmo-ccbunney committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    b4028d7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a8110f3 View commit details
    Browse the repository at this point in the history
  3. SHAVEIO now array

    ukmo-ccbunney committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    6adadff View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    569409b View commit details
    Browse the repository at this point in the history
  5. Updated the two implicit solver (PDLIB) W3SRCE calls (untested)

    Also removed some old code and unused variables.
    ukmo-ccbunney committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    e43c8cf View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    42e5ab3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2511ba3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b9ee6c7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    25a2bc3 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Configuration menu
    Copy the full SHA
    d2406b1 View commit details
    Browse the repository at this point in the history
  2. Bugfix:

      - EMEAN had wrong index variable
      - D_INP needs ISEA in Miche Limiter calculation
    ukmo-ccbunney committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    fb6c41a View commit details
    Browse the repository at this point in the history
  3. Removed the optional VSIO, VDIO and SHAVEIO arguments to W3SRCE for the

    pre implicit call. They are causing problems as they are not allocated.
    ukmo-ccbunney committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    7804ce4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    df5b22a View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Configuration menu
    Copy the full SHA
    5e03953 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Configuration menu
    Copy the full SHA
    fee16b1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d62b43f View commit details
    Browse the repository at this point in the history
  3. Fixed FPI array indices; this is now using a local calculaion for ISEA.

    Might want to change this at some point to use chunked array (ST2 only)
    Also added new code to write local CHUNKED arrays back to full seapoint
    grid at end of chunk loop - some variables like USTAR are returned back
    to w3wave.
    ukmo-ccbunney committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    8808cae View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Configuration menu
    Copy the full SHA
    3de633e View commit details
    Browse the repository at this point in the history
  2. More bad indices

    ukmo-ccbunney committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    cff917e View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Configuration menu
    Copy the full SHA
    d763900 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9514323 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Configuration menu
    Copy the full SHA
    bc400f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. A few syntax error/typo bug fixes.

    Also calculate DTDYN correctly for implicit solver
    ukmo-ccbunney committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    6577aa5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7579392 View commit details
    Browse the repository at this point in the history
  3. Avoid zeroing whole TAUICE and PHICE arrays.

    Zeroing them element-wise later on.
    Was causing B4B reproducibility issues in regtests.
    ukmo-ccbunney committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    e487df5 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Configuration menu
    Copy the full SHA
    f5d9bc5 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Fixed missing index BRLAMBDA

    Added some comments
    ukmo-ccbunney committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    d13e3b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    98614cd View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Configuration menu
    Copy the full SHA
    f66604f View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Change exit points for implicit source terms - need to ensure all

    elements in chunk have been completed before exiting.
    Moved initialisaton of WHITECAP outside of chunk loop (was zeroing
    previous calculations)
    ukmo-ccbunney committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    c97fd61 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0cc41e7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9c26094 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b8b820d View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Comment

    ukmo-ccbunney committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    a40da20 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Configuration menu
    Copy the full SHA
    52b69c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Configuration menu
    Copy the full SHA
    34761c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3410149 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Configuration menu
    Copy the full SHA
    bcb6e2c View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Configuration menu
    Copy the full SHA
    f69f191 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Configuration menu
    Copy the full SHA
    5d7937a View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Configuration menu
    Copy the full SHA
    07896d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. WW3_SHEL and WW3_MULTI now read WW3_SRC_TILE_SIZE environment variable

    to set tile/chunk size in new refactored W3SRCEMD:W3SRCE routine.
    ukmo-ccbunney committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    f0d54a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8711b4f View commit details
    Browse the repository at this point in the history
  3. More tidy up

    ukmo-ccbunney committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    efde9a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Configuration menu
    Copy the full SHA
    44f504a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e1afdb2 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Configuration menu
    Copy the full SHA
    d3fb4e1 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Configuration menu
    Copy the full SHA
    6bddf5a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8400d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Configuration menu
    Copy the full SHA
    075f5db View commit details
    Browse the repository at this point in the history
  2. Fixed typo

    ukmo-ccbunney committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    02b1954 View commit details
    Browse the repository at this point in the history
  3. Another stupid typo...

    ukmo-ccbunney committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    71ed812 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    262842f View commit details
    Browse the repository at this point in the history
  5. Update change log

    ukmo-ccbunney committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    2d96f90 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    848edb1 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Missing trailing comma

    ukmo-ccbunney committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    e65f96f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff0653c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d304af0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3fd2293 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5a2e281 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a4eb6ee View commit details
    Browse the repository at this point in the history
  7. Typo again

    ukmo-ccbunney committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    8c022e2 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Typo

    ukmo-ccbunney committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    873f1b0 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Configuration menu
    Copy the full SHA
    f87934f View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Configuration menu
    Copy the full SHA
    dd7ad88 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Configuration menu
    Copy the full SHA
    0fa7e36 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Configuration menu
    Copy the full SHA
    9afcff2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    be5de16 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Configuration menu
    Copy the full SHA
    2d9b019 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Configuration menu
    Copy the full SHA
    345d9b0 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Configuration menu
    Copy the full SHA
    136e5de View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Configuration menu
    Copy the full SHA
    41671b9 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Configuration menu
    Copy the full SHA
    d4bc3f7 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Configuration menu
    Copy the full SHA
    2df466a View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Configuration menu
    Copy the full SHA
    6ad8078 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Configuration menu
    Copy the full SHA
    f15870e View commit details
    Browse the repository at this point in the history