Merged the atms_n20 yaml file into RDASApp. #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShunLiu-NOAA
requested review from
SamuelDegelia-NOAA,
hu5970 and
HaidaoLin-NOAA
| obs operator: | ||
| name: CRTM | ||
| Absorbers: [H2O,O3,CO2] | ||
| Clouds: [Water, Ice] |
There was a problem hiding this comment.
HI Xiaoyan, did you see any differences with and without adding cloud inputs? Thanks!
There was a problem hiding this comment.
HI Xiaoyan, did you see any differences with and without adding cloud inputs? Thanks!
Yes, both the data passed QC and simulated brightness temperature are different. I will upload some figures in this PR to show these difference.
| obsdataout: | ||
| engine: | ||
| type: H5File | ||
| obsfile: atms_n20_hofx.nc4 |
There was a problem hiding this comment.
Based on this recent PR: #241 from @guoqing-noaa , it would be better to rename the diag/hofx file to be something like: jdiag_atms_n20.nc4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is going to merge the ATMS NOAA_20 JEDI yaml file into RDASApp validated yaml file templates.
As the test in issue #203, atms_n20 data has been tested in MPAS_JEDI including all QC filters and bias correction. Not only the ioda data converted from regular feed bufr data has been tested, but also the ioda data converted from combined regular feed, DBNet, and ESRs bufr data has been tested too.
In addition, this atms_n20 yaml file has included the online domain check filters as described in and issue #224, and removed the 'circle domain check' filter
The Ens3Dvar ctests has passed with this yaml file added on top of the existing yaml file templates.
The atms_n20 ioda data and the satbias files are
atms_n20.satbias.nc4 atms_n20.satbias_cov.nc4 atms_n20.tlapse.txt ioda_atms_n20.ncWhich are under:
/scratch2/NCEPDEV/fv3-cam/Xiaoyan.Zhang/noscrub/JEDI/RDASApp_1107/expr/mpas_2024052700/data/obs