Add bound check for each observation and make some changes to the com…

…ments
NOAA-EMC · Dec 3, 2024 · 2f5eb33 · 2f5eb33
1 parent 4283898
commit 2f5eb33
Show file tree

Hide file tree

Showing 4 changed files with 52 additions and 20 deletions.
diff --git a/rrfs-test/validated_yamls/templates/obtype_config/adpsfc_airTemperature_187.yaml b/rrfs-test/validated_yamls/templates/obtype_config/adpsfc_airTemperature_187.yaml
@@ -39,7 +39,7 @@
          # ------------------
          # airTemperature (187)
          # ------------------
-         # Reject all obs with ObsType /= 187, QualityMarker = 4 -15
+         # Reject all observations with QualityMarker > 3
          - filter: RejectList
            apply at iterations: 0,1
            where:
@@ -71,8 +71,7 @@
            filter variables:
            - name: airTemperature
            where:
-           - variable:
-               name: ObsType/airTemperature
+           - variable: ObsType/airTemperature
              is_in: 187
            action:
              name: assign error
@@ -84,7 +83,7 @@
                  xvals: [110000, 105000, 100000, 95000, 90000, 85000, 80000, 75000, 70000, 65000, 60000, 55000, 50000, 45000, 40000, 35000, 30000, 25000, 20000, 15000, 10000, 7500, 5000, 4000, 3000, 2000, 1000, 500, 400, 300, 200, 100, 0]
                  errors: [2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585, 2.2585]
 
-         # error inflation based on pressure check (setupt.f90)
+         # Error inflation based on pressure check (setupt.f90)
          - filter: Perform Action
            filter variables:
            - name: airTemperature
@@ -103,6 +102,14 @@
                  # options for temperature and humidity in GSI.
                  #surface observation error ramp: true
 
+         # Bounds Check
+         - filter: Bounds Check
+           apply at iterations: 0,1
+           filter variables:
+           - name: airTemperature
+           minvalue: 100
+           maxvalue: 400
+
          # Create temporary ObsErrorData
          - filter: Variable Assignment
            apply at iterations: 0,1
@@ -165,7 +172,7 @@
              name: reject
            defer to post: true
 
-         # Gross Error Check
+         # Gross Error Check: cgross*0.7 if QualityMarker=3
          - filter: Background Check
            apply at iterations: 0,1
            filter variables:

diff --git a/rrfs-test/validated_yamls/templates/obtype_config/adpsfc_specificHumidity_187.yaml b/rrfs-test/validated_yamls/templates/obtype_config/adpsfc_specificHumidity_187.yaml
@@ -39,7 +39,7 @@
          # ------------------
          # specificHumidity (187)
          # ------------------
-         # Reject all obs with ObsType /= 187, QualityMarker = 4 -15
+         # Reject all observations with QualityMarker > 3
          - filter: RejectList
            apply at iterations: 0,1
            where:
@@ -71,8 +71,7 @@
            filter variables:
            - name: specificHumidity
            where:
-           - variable:
-               name: ObsType/specificHumidity
+           - variable: ObsType/specificHumidity
              is_in: 187
            action:
              name: assign error
@@ -84,7 +83,7 @@
                  xvals: [110000, 105000, 100000, 95000, 90000, 85000, 80000, 75000, 70000, 65000, 60000, 55000, 50000, 45000, 40000, 35000, 30000, 25000, 20000, 15000, 10000, 7500, 5000, 4000, 3000, 2000, 1000, 500, 400, 300, 200, 100, 0]
                  errors: [0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912, 0.05912]
 
-         # error inflation based on pressure check (setupt.f90)
+         # Error inflation based on pressure check (setupq.f90)
          - filter: Perform Action
            filter variables:
            - name: specificHumidity
@@ -104,6 +103,14 @@
                  # options for temperature and humidity in GSI.
                  #surface observation error ramp: true
 
+         # Bounds Check
+         - filter: Bounds Check
+           apply at iterations: 0,1
+           filter variables:
+           - name: specificHumidity
+           minvalue: 0.0
+           maxvalue: 1.0
+
          # Create temporary ObsErrorData
          - filter: Variable Assignment
            apply at iterations: 0,1
@@ -166,7 +173,7 @@
              name: reject
            defer to post: true
 
-         # Gross Error Check
+         # Gross Error Check: cgross*0.7 if QualityMarker=3
          - filter: Background Check
            apply at iterations: 0,1
            filter variables:

diff --git a/rrfs-test/validated_yamls/templates/obtype_config/adpsfc_stationPressure_187.yaml b/rrfs-test/validated_yamls/templates/obtype_config/adpsfc_stationPressure_187.yaml
@@ -36,7 +36,7 @@
          # ------------------
          # stationPressure (187)
          # ------------------
-         # Reject all obs with ObsType /= 187, QualityMarker = 4 -15
+         # Reject all observations with QualityMarker > 3
          - filter: RejectList
            apply at iterations: 0,1
            where:
@@ -68,8 +68,7 @@
            filter variables:
            - name: stationPressure
            where:
-           - variable:
-               name: ObsType/stationPressure
+           - variable: ObsType/stationPressure
              is_in: 187
            action:
              name: assign error
@@ -107,9 +106,17 @@
                name: ObsFunction/ObsErrorFactorSfcPressure
                options:
                  geovar_geomz: geopotential_height
-                 #geovar_sfc_geomz: surface_geometric_height
+                 #geovar_sfc_geomz: geopotential_height_at_surface
                  station_altitude: height
 
+         # Bounds Check
+         - filter: Bounds Check
+           apply at iterations: 0,1
+           filter variables:
+           - name: stationPressure
+           minvalue: 20000.0
+           maxvalue: 120000.0
+
          # Create temporary ObsErrorData
          - filter: Variable Assignment
            apply at iterations: 0,1
@@ -172,7 +179,7 @@
              name: reject
            defer to post: true
 
-         # Gross Error Check
+         # Gross Error Check: cgross*0.7 if QualityMarker=3
          - filter: Background Check
            apply at iterations: 0,1
            filter variables:

diff --git a/rrfs-test/validated_yamls/templates/obtype_config/adpsfc_winds_287.yaml b/rrfs-test/validated_yamls/templates/obtype_config/adpsfc_winds_287.yaml
@@ -46,7 +46,7 @@
          # ------------------
          # wind (287)
          # ------------------
-         # Reject all obs with ObsType /= 287, QualityMarker = 4 -15
+         # Reject all observations with QualityMarker > 3
          - filter: RejectList
            apply at iterations: 0,1
            where:
@@ -82,9 +82,8 @@
            - name: windEastward
            - name: windNorthward
            where:
-           - variable:
-               name: ObsType/windEastward
-               is_in: 287
+           - variable: ObsType/windEastward
+             is_in: 287
            action:
              name: assign error
              error function:
@@ -95,7 +94,7 @@
                  xvals: [110000, 105000, 100000, 95000, 90000, 85000, 80000, 75000, 70000, 65000, 60000, 55000, 50000, 45000, 40000, 35000, 30000, 25000, 20000, 15000, 10000, 7500, 5000, 4000, 3000, 2000, 1000, 500, 400, 300, 200, 100, 0]
                  errors: [1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874, 1.5874]
 
-         # error inflation based on pressure check (setupw.f90)
+         # Error inflation based on pressure check (setupw.f90)
          - filter: Perform Action
            filter variables:
            - name: windEastward
@@ -130,6 +129,17 @@
                  AddObsHeightToStationElevation: true
                  AssumedSfcWndObsHeight: 10
 
+         # Bounds Check
+         - filter: Bounds Check
+           apply at iterations: 0,1
+           filter variables:
+           - name: windEastward
+           - name: windNorthward
+           minvalue: -130
+           maxvalue: 130
+           action:
+             name: reject
+
          # Gross Error Check
          - filter: Background Check
            apply at iterations: 0,1
@@ -169,6 +179,7 @@
              name: reject
            defer to post: true
 
+         # Gross Error Check: cgross*0.7 if QualityMarker=3
          - filter: Background Check
            apply at iterations: 0,1
            filter variables: