Extend testing (splat, sptrung, sptrungv, sppad, splaplac) #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderRichert-NOAA
force-pushed
the
add_testing_Oct2023
branch
from
4de6aed
to
da5467b
Compare
AlexanderRichert-NOAA
force-pushed
the
add_testing_Oct2023
branch
from
da5467b
to
ecdef81
Compare
AlexanderRichert-NOAA
force-pushed
the
add_testing_Oct2023
branch
from
6ae0ffa
to
f0989d6
Compare
AlexanderRichert-NOAA
force-pushed
the
add_testing_Oct2023
branch
from
a0746a3
to
45885e9
Compare
AlexanderRichert-NOAA
force-pushed
the
add_testing_Oct2023
branch
from
5bf3ec9
to
f74acdd
Compare
|
Excellent. When you're done, let me know the new sp test coverage so I can update the paper/poster. |
AlexanderRichert-NOAA
force-pushed
the
add_testing_Oct2023
branch
from
ac12e67
to
4f87655
Compare
|
@edwardhartnett this PR will bring up the line coverage to 51.4%. If you're okay with approving this, I think it's good to go, then I'll probably add a second batch of tests by the end of the week, where my goal is to focus on some of the more commonly used routines in operations. |
AlexanderRichert-NOAA
changed the title
|
@edwardhartnett as of the latest commit, the line coverage is 52.6% (up from ~37% I think), and function coverage is 64.6%. This testing seems to hit the highlights of what's used in operations, so after we merge this I think I'm ready to start looking at merging sp into ip. |
AlexanderRichert-NOAA
changed the title
Hang-Lei-NOAA
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends splat testing (idrt=256 case), adds tests for sptrung and sptrungv based on a couple of ip unit tests, and tests for sppad and splaplac. For fun, I am also experimenting with setting timeouts on the unit tests to prevent unintended performance degradation. I am also reducing the number of spack unit tests.
Addresses NOAA-EMC/NCEPLIBS-ip#224, NOAA-EMC/NCEPLIBS-ip#221