Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --output-on-failure to ctest #156

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Add --output-on-failure to ctest #156

merged 1 commit into from
Aug 18, 2021

Conversation

kgerheiser
Copy link
Contributor

Related to #155 to show error message when tests fail.

@jbathegit
Copy link
Collaborator

Interesting that the Python checks are now working. As noted in #135, @edwardhartnett and I had problems getting these to work even before I tried to submit my PR #155. I'm really puzzled here.

@jbathegit
Copy link
Collaborator

I guess I could go ahead and merge this PR back into develop, then re-baseline my jba_noDA branch and re-run the test and see what happens(?)

@aerorahul
Copy link
Contributor

@jbathegit
If the python tests fail at any point, please open an issue immediately.
We added those tests to ensure they stay working, and not to be ignored in case they fail.

@aerorahul aerorahul merged commit 2e7f0ba into NOAA-EMC:develop Aug 18, 2021
@jbathegit
Copy link
Collaborator

@jbathegit
If the python tests fail at any point, please open an issue immediately.
We added those tests to ensure they stay working, and not to be ignored in case they fail.

@edwardhartnett did open an issue for this back in April when he first noticed this (see #135). But it's still pending/unresolved.

@edwardhartnett
Copy link
Contributor

I was just looking at all my issues and thinking that maybe zenhub will help... ;-)

Yes, python tests broke when I added code coverage. Not sure why. But that would have little to do with this issue, which is a cmake option...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants