Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/b2i tropical #1311

Merged
merged 65 commits into from
Oct 16, 2024
Merged

Feature/b2i tropical #1311

merged 65 commits into from
Oct 16, 2024

Conversation

givelberg
Copy link
Collaborator

Two converters added to the previous 6 bufr to ioda converters:
drifters and tropical moorings.
Both are taken from the dbuoy bufr input file.
There is also a small bug correction in the cmake file.

Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from minor comments

@KatherineLukens-NOAA
Copy link
Collaborator

I agree with Andy: I just have some minor comments, otherwise it looks good to me

@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Oct 8, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Oct 8, 2024
@emcbot
Copy link

emcbot commented Oct 8, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Tue Oct  8 15:55:43 UTC 2024 on hfe11
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Oct  8 16:45:06 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Oct  8 19:37:34 UTC 2024
Tests: 83% tests passed, 8 tests failed out of 46
	1955 - test_gdasapp_WCDA-3DVAR-C48mx500_gdasmarineanlinit_202103241800 (Failed)
	1956 - test_gdasapp_WCDA-3DVAR-C48mx500_gdasmarineanlvar_202103241800 (Failed)
	1957 - test_gdasapp_WCDA-3DVAR-C48mx500_gdasmarineanlchkpt_202103241800 (Failed)
	1972 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1311/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Oct 8, 2024
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And once again @givelberg , your ctests are not triggered. When somebody builds the gdasapp, your tests should be part of the default list, at least on hera and hercules/orion.

@guillaumevernieres
Copy link
Contributor

@givelberg , your branch is behind develop. Let us know here when this is ready to review.

@givelberg
Copy link
Collaborator Author

@guillaumevernieres I think this is updated now.

@guillaumevernieres
Copy link
Contributor

I'm going to merge this and deal with the consequences later ...

@guillaumevernieres guillaumevernieres merged commit a1cb2ee into develop Oct 16, 2024
5 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/b2iTropical branch October 16, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants