Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build GDASApp outside of global-workflow #1306

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Build GDASApp outside of global-workflow #1306

merged 3 commits into from
Sep 30, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Sep 30, 2024 •
edited
Loading

Tests in tests/gw-ci require global-workflow. As such, GDASApp can not build outside of g-w. This PR places gw-ci tests under the flag RUN_GW_CI. gw-ci tests are built when RUN_GI_CW is set to ON. The default is OFF. With this change GDASApp can be built without g-w.

Resolves #1305

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Sep 30, 2024
@RussTreadon-NOAA RussTreadon-NOAA added orion-RT Queue for automated testing on Orion hera-RT Queue for automated testing on Hera labels Sep 30, 2024
@emcbot emcbot added hera-RT-Running Automated testing running on Hera and removed hera-RT Queue for automated testing on Hera labels Sep 30, 2024
@RussTreadon-NOAA RussTreadon-NOAA removed the orion-RT Queue for automated testing on Orion label Sep 30, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

At present orion-RT is not active on Orion.

@emcbot
Copy link

emcbot commented Sep 30, 2024

Automated GDASApp Testing Results:
Machine: hera

Start: Mon Sep 30 17:19:41 UTC 2024 on hfe11
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Sep 30 18:05:51 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Sep 30 18:07:26 UTC 2024
Tests: 96% tests passed, 1 tests failed out of 25
	1893 - test_gdasapp_aero_gen_3dvar_yaml (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/PR/1306/GDASApp/build/log.ctest

@emcbot emcbot added hera-RT-Failed Automated testing failed on Hera and removed hera-RT-Running Automated testing running on Hera labels Sep 30, 2024
@RussTreadon-NOAA RussTreadon-NOAA added hera-RT Queue for automated testing on Hera and removed hera-RT-Failed Automated testing failed on Hera labels Sep 30, 2024
@emcbot emcbot added hera-RT-Running Automated testing running on Hera and removed hera-RT Queue for automated testing on Hera labels Sep 30, 2024
@emcbot
Copy link

emcbot commented Sep 30, 2024

Automated GDASApp Testing Results:
Machine: hera

Start: Mon Sep 30 19:40:24 UTC 2024 on hfe06
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Sep 30 20:24:56 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Sep 30 20:26:15 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 24

@emcbot emcbot added hera-RT-Passed Automated testing successful on Hera and removed hera-RT-Running Automated testing running on Hera labels Sep 30, 2024
guillaumevernieres
guillaumevernieres approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RussTreadon-NOAA ... for fixing things that I broke!

@guillaumevernieres guillaumevernieres merged commit 3a34812 into develop Sep 30, 2024
11 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/gwci branch September 30, 2024 20:42
@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @guillaumevernieres !

jiaruidong2017 pushed a commit that referenced this pull request Oct 3, 2024
@RussTreadon-NOAA @jiaruidong2017
Build GDASApp outside of global-workflow (#1306)
2d2a5e4 
Tests in `tests/gw-ci` require global-workflow. As such, GDASApp can not
build outside of g-w. This PR places gw-ci tests under the flag
`RUN_GW_CI`. gw-ci tests are built when `RUN_GI_CW` is set to `ON`. The
default is `OFF`. With this change GDASApp can be built without g-w.

Resolves #1305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
hera-RT-Passed Automated testing successful on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to build stand-alone GDASApp
3 participants
@RussTreadon-NOAA @emcbot @guillaumevernieres