minor NMisNumeric bugfix

LICENSE

@@ -1,21 +1,2 @@
-MIT License
-
-Copyright (c) 2019-2022 Philip Delff
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+YEAR: 2019-2022
+COPYRIGHT HOLDER: Philip Delff

NEWS.md

@@ -53,6 +53,9 @@
 
 * addTAPD was not respecting subset.dos for all generated columns. 
 
+* NMisNumeric would interpret a NA of class character or logical as
+  non-numeric. Fixed.
+
 ## Other improvements
 * Internally, combination of input and output data without a row
   identifier is simplified.

R/NMisNumeric.R

@@ -30,11 +30,12 @@ NMisNumeric <- function(x,na.strings=".",each=FALSE){
             inherits(x, "POSIXt")  ||
             inherits(x, "Date")
     }
-
+    
     ok <- rep(TRUE,length(x))
     if(is.logical(x) || is.timestamp(x)) {
-        ok[] <- FALSE
+        ok[!is.na(x)] <- FALSE
     } else if(!is.numeric(x)){
+
         ok[!is.na(x)&!as.character(x)%in%na.strings] <- 
             suppressWarnings(!is.na(as.numeric(as.character(x)[!is.na(x)&!as.character(x)%in%na.strings])))
     }

devel/todo.org

@@ -293,9 +293,7 @@ The information is sufficient when taking into account the linesep
 arguement. If length(lines) and linesep is given, a warning must be
 issued. Once done, NMgetSection must be updated as well.
 *** NMisNumeric
-**** TODO [#A] NA_character is not recognized as numeric
-NMisNumeric(c(NA)) is FALSE
-NMisNumeric(NA_real_) is TRUE
+**** DONE NA_character is not recognized as numeric
 *** NMscanInput
 **** DONE Test with multiple filters on the same column
 like IGNORE(ID=2) IGNORE(ID=3)

tests/testthat/testOutput/stampedData_8_meta.txt

@@ -1,4 +1,4 @@
-"parameter","value"
-"DataCreateScript","A simple test"
-"CreationTime","2021-11-21 11:00:00 EST"
-"writtenTo","testOutput/stampedData_8.csv"
+"parameter","value"
+"DataCreateScript","A simple test"
+"CreationTime","2021-11-21 11:00:00 EST"
+"writtenTo","testOutput/stampedData_8.csv"

tests/testthat/test_NMisNumeric.R

@@ -24,3 +24,21 @@ test_that("element-wise",{
 
     expect_equal_to_reference(res,fileRef,version=2)
 })
+
+
+test_that("NA's",{
+    fileRef <- "testReference/NMisNumeric_4.rds"
+
+    dttest <- data.table(logic=NA
+                        ,char2=NA_character_
+                        ,num=NA_real_
+                        ,int=NA_integer_
+                         )
+
+    res <- sapply(dttest,NMisNumeric)
+
+res
+
+
+    expect_equal_to_reference(res,fileRef,version=2)
+})