Add AlignedWriter for ZonefileFmt #446
Open
+128
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tertsdiepraam
force-pushed
the
aligned-zonefile-printing
branch
from
b34e005
to
d7d3cd7
Compare
tertsdiepraam
force-pushed
the
aligned-zonefile-printing
branch
from
d7d3cd7
to
d61249d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to https://github.com/NLnetLabs/domain/pull/445/files.
I'm not sure about the interface, because the
pretty: booldoesn't work anymore, and it was already not very good. Maybe these should be separate methods:display_zonefile,display_zonefile_multiline& display_zonefile_aligned`? Feedback welcome!