Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FromStr for zonemd Scheme and Algorithm #444

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mozzieongit
Copy link
Member

While writing the dnst signzone zonemd argument parsing, I noticed that zonemd::Scheme and zonemd::Algorithm implement neither FromStr nor a from_mnemonic function (as with the enums created with the iana int_enum macro).
I was unsure which one should be used, but settled on FromStr with both number and mnemonic, as it allows an easy use of str::parse.

@mozzieongit mozzieongit requested a review from a team November 20, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant