Add missing required features to Cargo.toml for examples #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximon18
changed the title
…r (also ensures a final success doesn't cause previous failures to be ignored).
This reverts commit 1ad3aa3.
tertsdiepraam
approved these changes
Nov 8, 2024
tertsdiepraam
pushed a commit
that referenced
this pull request
Nov 22, 2024
* Add missing required features to serve-zone example. * Fix required-features listed in Cargo.toml for the query-zone example. * Fix required-features listed in Cargo.toml for the client-transports example. * Echo all run commands to check examples, and exit immediately on error (also ensures a final success doesn't cause previous failures to be ignored). * Fix required-features listed in Cargo.toml for the server-transports example. * Remove unused import except when feature is enabled that needs it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other examples have similar issues. This PR aims to fix them all.
Note to self: I should investigate why
tokio-streamneeds to be specified explicitly, but for now this at least makes the example easier to run.