-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network servers should not ignore ServiceError
.
#390
Open
ximon18
wants to merge
9
commits into
main
Choose a base branch
from
handle-service-errors-in-servers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f00bd0b - Browse repository at this point
Copy the full SHA f00bd0bView commit details -
Handle ServiceError by halting response processing for a request and …
…returning an appropriate DNS error message. Factor common service invoking and response processing code out to new trait ServiceInvoker and implement the network server specific parts for the UDP and TCP servers. Also simplifies some trait bounds.
Configuration menu - View commit details
-
Copy full SHA for 2bae2e1 - Browse repository at this point
Copy the full SHA 2bae2e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 890c4c8 - Browse repository at this point
Copy the full SHA 890c4c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f53310c - Browse repository at this point
Copy the full SHA f53310cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e955ce - Browse repository at this point
Copy the full SHA 7e955ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4863cc0 - Browse repository at this point
Copy the full SHA 4863cc0View commit details
Commits on Oct 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d1ea1ed - Browse repository at this point
Copy the full SHA d1ea1edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 183ae91 - Browse repository at this point
Copy the full SHA 183ae91View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b90be94 - Browse repository at this point
Copy the full SHA b90be94View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.