Add an optional push limit to MessageBuilder
.
#348
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when wanting to "reserve" space such that pushes to a message at one point in the code will leave enough room for subsequent pushes later, e.g. of OPT or TSIG RRs.
Note: I initially implemented this using
Option<u16>
but:MessageBuilder
doesn't itself impose a 65k limit on messages sou16
is not appropriate.Option<usize>
felt clumsy and slightly less efficient than just comparing tousize::MAX
andusize::MAX
seems a safe enough hack, but if not we can useOption
if that is felt to be safer/better.