Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pypi publishing #376

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

f-hafner
Copy link
Contributor

Description

This proposes a fix to #372.

I just now realise #373 asks for a workflow. I had also wondered whether I should add that. For now, it's just in the sample code in the README.dev.md file. I can transfer this into a workflow file -- can you give some feedback on the sample code? I copied from a workflow that works, but perhaps you have suggestions for improvement.

@f-hafner f-hafner requested a review from egpbos March 21, 2024 10:50
@f-hafner
Copy link
Contributor Author

f-hafner commented Mar 22, 2024

@fdiblen
Copy link
Member

fdiblen commented Aug 27, 2024

Hey @f-hafner ,

The template is using copier now. Will you have time to update and complete this PR?

@f-hafner
Copy link
Contributor Author

@fdiblen , I have to get familiar with the new template but I can work on this

@fdiblen
Copy link
Member

fdiblen commented Sep 16, 2024

@fdiblen , I have to get familiar with the new template but I can work on this

I think it makes more sense to close this pull request and create a new one. I will close this PR. Please let us know if you need help with creating a new one.

@fdiblen fdiblen closed this Sep 16, 2024
@egpbos
Copy link
Member

egpbos commented Sep 18, 2024

Was it really necessary to close this? It seemed like the merge conflicts were minor, especially because one file is completely new.

@egpbos egpbos reopened this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants