-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added openPage in webpack.config.babel.js #65
base: master
Are you sure you want to change the base?
Conversation
And please follow the commit log structure as shown below.
if your commit fixes some issue, then note in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ScareCROW21 I don't think this'll work. Please check the comments above and proceed.
Yes. Didn't see the comments. Will do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the changes noted here.
@@ -1,11 +1,11 @@ | |||
import path from 'path'; | |||
import path from 'path'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary change. Please drop this.
webpack.config.babel.js
Outdated
import webpack from 'webpack'; | ||
|
||
const config = { | ||
devServer: { | ||
hot: true, | ||
inline: true, | ||
openPage: 'https://localhost:8000' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop this newline, please.
@@ -56,7 +56,8 @@ const config = { | |||
}, | |||
output: { | |||
filename: 'bundle.js', | |||
path: path.resolve(__dirname, 'build', 'client') | |||
path: path.resolve(__dirname, 'build', 'client'), | |||
publicPath: "localhost:8080/dev-server/bundle.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"/dev-server"
would be enough. You shouldn't be specifying the entire scheme here.
And please never merge master branch into your branches. Keep the commit history linear by rebasing stuff. |
And I don't see the need for 6 commits here. We can just do it in two, since it's a minor change. |
Also, please use |
I made a new PR. Tell me if any changes. |
It doesn't seem to work. What am I doing wrong?