Fixing searching bug on proceedings page #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searching the proceedings page with
Ctrl/Cmd+F
(browser's Find feature) brings mostly results where nothing seems to be found (no highlighted text).This makes the search-ability issues of NIME proceedings even worse than discussed in #4. The empty results appear because all abstracts and BibTex are included in the page's DOM even when they are not visible. The code responsible for this behaviour is the following:
nime-website/assets/styles.scss
Lines 55 to 64 in a9f7426
Making the
max-height
of abstracts and BibTex containers zero hides them but they are still searchable.Using
display
for hiding fixes the issue.