Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing searching bug on proceedings page #25

Merged
merged 1 commit into from
Nov 22, 2020

Conversation

dimitriaatos
Copy link
Contributor

@dimitriaatos dimitriaatos commented Nov 22, 2020

Searching the proceedings page with Ctrl/Cmd+F (browser's Find feature) brings mostly results where nothing seems to be found (no highlighted text).
search issue
This makes the search-ability issues of NIME proceedings even worse than discussed in #4. The empty results appear because all abstracts and BibTex are included in the page's DOM even when they are not visible. The code responsible for this behaviour is the following:

.collapse {
display: block;
max-height: 0px;
overflow: hidden;
/*transition: max-height .5s cubic-bezier(0, 1, 0, 1);*/
&.show {
max-height: 99em;
/*transition: max-height .5s ease-in-out;*/
}
}

Making the max-height of abstracts and BibTex containers zero hides them but they are still searchable.
Using display for hiding fixes the issue.

.collapse {
  display: none;
&.show {
    display: block;
  }
}

@cpmpercussion
Copy link
Collaborator

Good find! Not sure why I didn't do it that way in the first place, seems much more straightforward!

@cpmpercussion cpmpercussion merged commit eacc917 into NIME-conference:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants