Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for issue #1289 #1291

Merged
merged 4 commits into from
Dec 9, 2024
+26 −24
Merged

Bug fix for issue #1289 #1291

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df6c5e7
Bug fix for issue #1289
sshu88 Nov 20, 2024
0eb912c
Update EDLoggingMortalityMod.F90
sshu88 Dec 2, 2024
914393a
Update FatesConstantsMod.F90
sshu88 Dec 2, 2024
77e8948
Merge tag 'sci.1.80.3_api.37.0.0' into fatesluc_cbasedhrv_v2
glemieux Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion biogeochem/EDLoggingMortalityMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ subroutine LoggingMortality_frac( pft_i, dbh, canopy_layer, lmort_direct, &
! transfer of area to secondary land is based on overall area affected, not just logged crown area
! l_degrad accounts for the affected area between logged crowns
if(prt_params%woody(pft_i) == itrue)then ! only set logging rates for trees
if (cur_harvest_tag == 0) then
if (cur_harvest_tag == 0 .or. cur_harvest_tag == 2) then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @sshu88 -- would it be possible to replace these integers that you are comparing cur_harvest_tag to, here and elsewhere, with named integer constants that describe more clearly what these conditions refer to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suggestion! I updated the code.

! direct logging rates, based on dbh min and max criteria
if (dbh >= logging_dbhmin .and. .not. &
((logging_dbhmax < fates_check_param_set) .and. (dbh >= logging_dbhmax )) ) then
Expand Down