Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add n_term_mort_types to the fates_maxElementsPerSite calculation to resolve potential restart indexing issues #1189

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

glemieux
Copy link
Contributor

@glemieux glemieux commented Apr 18, 2024

Description:

The pull request is a quick fix to resolve #1182 (also duplicate #1188). A longer term fix for these issues would be to avoid providing these history terms during satellite phenology mode, when they are not needed as suggested by @ckoven.

Collaborators:

@rgknox

Expectation of Answer Changes:

This is not expected to change answers

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

TBD

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

Copy link
Contributor

@rgknox rgknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@glemieux
Copy link
Contributor Author

glemieux commented Apr 22, 2024

Regression testing on derecho is complete. All expectected tests pass b4b. The test previously failing exact restart, ERS_Ld30.f45_f45_mg37.I2000Clm51FatesSpCruRsGs.derecho_intel.clm-FatesColdSatPhen, is now passing.

Results: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr1189-fates

@glemieux glemieux merged commit 5284bd0 into NGEET:main Apr 22, 2024
1 check passed
@glemieux glemieux deleted the spmode-restart-indexing-hotfix branch May 29, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restart indexing error for rio_termnindiv_cano_siscpf with multiple node layout SP restart crash
2 participants