-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate parameter file switches that are moving to HLM namelist #1300
Open
glemieux
wants to merge
10
commits into
NGEET:main
Choose a base branch
from
glemieux:parameter-switch-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
glemieux
force-pushed
the
parameter-switch-migration
branch
from
December 11, 2024 19:41
67e0842
to
e8ae746
Compare
glemieux
force-pushed
the
parameter-switch-migration
branch
4 times, most recently
from
December 11, 2024 22:57
fb6bd7a
to
c89b770
Compare
glemieux
force-pushed
the
parameter-switch-migration
branch
from
December 12, 2024 19:29
c89b770
to
ef51623
Compare
Noting that we have concurrent plans to change the hydro solver default, possibly the respiration default, or others. This is just a reminder to make sure that those changes do not get lost in the shuffle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1295
To be coordinated with ESCOMP/CTSM#2904
Description:
Parameter switches to be moved:
fates_daylength_factor_switch
fates_hydro_solver
fates_leaf_photo_tempsens_model
fates_leaf_stomatal_assim_model
fates_leaf_stomatal_model
fates_maintresp_leaf_model
fates_mort_cstarvation_model
fates_rad_model
fates_regeneration_model
Collaborators:
Expectation of Answer Changes:
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: