Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: all): support Angular 18 #899

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

BBboy01
Copy link

@BBboy01 BBboy01 commented Jul 31, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No
  1. TypeScript >=5.5.4
  2. nodejs >= 18

Other information

@BBboy01
Copy link
Author

BBboy01 commented Aug 7, 2024

CleanShot.2024-08-07.at.14.27.22.mp4

As angular 18 support use vite as dev server, require is unusable

removed raw-loader, like NZ-ZORRO use http request get source code

and unified the ui of code box action icons

@BBboy01
Copy link
Author

BBboy01 commented Aug 9, 2024

angular/angular#56945 (comment)

tsconfig.json
compilerOptions: {
"skipLibCheck": true
}

angular < 18.1.3 have ngtypecheck error, for now to run locally, please add code above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant