Updated .nuspec file and fixed build script

NEventStore · Dec 3, 2021 · 8ff8ee5 · 8ff8ee5
1 parent 35d6f2a
commit 8ff8ee5
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -54,6 +54,7 @@ git submodule update
 To build the project locally on a Windows Machine:
 
 - Install [Chocolatey](https://chocolatey.org/).
+- Optional: update `.\src\.nuget\NEventStore.Persistence.Sql.nuspec` file if needed (before creating relase packages).
 - Open a Powershell console in Administrative mode and run the build script `build.ps1` in the root of the repository.
 
 ## How to contribute
@@ -96,6 +97,10 @@ You can leave all values as default. Now your repository is GitFlow enabled.
 
 ### Note on Nuget version on Nuspec
 
+Remember to update `.\src\.nuget\NEventStore.Persistence.Sql.nuspec` file if needed (before creating relase packages).
+
+The .nuspec file is needed because the new `dotnet pack` command has problems dealing with ProjectReferences, submodules get the wrong version number.
+
 While we are on develop branch, (suppose we just bumped major number so the driver version number is 6.0.0-unstablexxxx), we need to declare that this persistence driver depends from a version greater than the latest published. If the latest version of NEventStore 5.x.x wave iw 5.4.0 we need to declare this package dependency as
 
 (5.4, 7)

diff --git a/build.ps1 b/build.ps1
@@ -1,6 +1,5 @@
 $configurationdefault = "Release"
 $artifacts = "../../artifacts"
-$nugetartifacts = "artifacts"
 
 $configuration = Read-Host 'Configuration to build [default: Release] ?'
 if ($configuration -eq '') {
@@ -48,4 +47,4 @@ Write-Host "NuGet Packages creation"
 #dotnet pack ./src/NEventStore.Persistence.Sql/NEventStore.Persistence.Sql.Core.csproj --no-build -c $configuration -o $artifacts -p:NuspecFile="" -p:NuspecProperties="pippo=$configuration;version=$nugetversion"
 
 #Write-Host nuget pack ./src/.nuget/NEventStore.Persistence.Sql.nuspec -properties "version=$nugetversion;configuration=$configuration"
-nuget pack ./src/.nuget/NEventStore.Persistence.Sql.nuspec -properties "version=$nugetversion;configuration=$configuration" -OutputDirectory $nugetartifacts
+nuget pack ./src/.nuget/NEventStore.Persistence.Sql.nuspec -properties "version=$nugetversion;configuration=$configuration" -OutputDirectory $artifacts
diff --git a/src/.nuget/NEventStore.Persistence.Sql.nuspec b/src/.nuget/NEventStore.Persistence.Sql.nuspec
@@ -21,19 +21,24 @@
 	-->
     <dependencies>
       <group targetFramework=".NETFramework4.6.1">
-        <dependency id="NEventStore" version="[8.0.0,9.0.0)" exclude="Build,Analyzers"/>
-        <dependency id="Microsoft.Extensions.Logging.Abstractions" version="5.0.0" exclude="Build,Analyzers" />
-        <dependency id="System.Data.SqlClient" version="4.8.2" exclude="Build,Analyzers" />
+        <dependency id="NEventStore" version="[9.0.0,10.0.0)" exclude="Build,Analyzers"/>
+        <dependency id="Microsoft.Extensions.Logging.Abstractions" version="6.0.0" exclude="Build,Analyzers" />
+        <dependency id="System.Data.SqlClient" version="4.8.3" exclude="Build,Analyzers" />
+      </group>
+      <group targetFramework="net6.0">
+        <dependency id="NEventStore" version="[9.0.0, 10.0.0)" exclude="Build,Analyzers" />
+        <dependency id="Microsoft.Extensions.Logging.Abstractions" version="6.0.0" exclude="Build,Analyzers" />
+        <dependency id="System.Data.SqlClient" version="4.8.3" exclude="Build,Analyzers" />
       </group>
       <group targetFramework="net5.0">
-        <dependency id="NEventStore" version="[8.0.0, 9.0.0)" exclude="Build,Analyzers" />
-        <dependency id="Microsoft.Extensions.Logging.Abstractions" version="5.0.0" exclude="Build,Analyzers" />
-        <dependency id="System.Data.SqlClient" version="4.8.2" exclude="Build,Analyzers" />
+        <dependency id="NEventStore" version="[9.0.0, 10.0.0)" exclude="Build,Analyzers" />
+        <dependency id="Microsoft.Extensions.Logging.Abstractions" version="6.0.0" exclude="Build,Analyzers" />
+        <dependency id="System.Data.SqlClient" version="4.8.3" exclude="Build,Analyzers" />
       </group>
       <group targetFramework=".NETStandard2.0">
-        <dependency id="NEventStore" version="[8.0.0,9.0.0)" exclude="Build,Analyzers"/>
-        <dependency id="Microsoft.Extensions.Logging.Abstractions" version="5.0.0" exclude="Build,Analyzers" />
-        <dependency id="System.Data.SqlClient" version="4.8.2" exclude="Build,Analyzers" />
+        <dependency id="NEventStore" version="[9.0.0,10.0.0)" exclude="Build,Analyzers"/>
+        <dependency id="Microsoft.Extensions.Logging.Abstractions" version="6.0.0" exclude="Build,Analyzers" />
+        <dependency id="System.Data.SqlClient" version="4.8.3" exclude="Build,Analyzers" />
       </group>
     </dependencies>
     <frameworkAssemblies>