Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to JupyterLab v4 #4

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Migration to JupyterLab v4 #4

wants to merge 12 commits into from

Conversation

mlhenderson
Copy link
Collaborator

@mlhenderson mlhenderson commented Jul 25, 2023 •
edited
Loading

  • Migrated to v4 template
  • Merged eslint settings into package.json and removed eslint files
  • Code cleanup
    • eliminate null assignment to widget
    • simplified logic for refreshing the announcement
    • eliminated repeated destruction/creation of the widget
    • log fetch failures to the web console
    • renamed css classes to be more specific to this extension
  • Added bullhorn symbol and reduced text in the status bar
  • Added default message for overlay when no announcement
  • Eliminated logic to track and check whether an announcement had been opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mlhenderson