[bidi][java] Avoid creating new instances of log entry event

NDViet · Jul 3, 2024 · 5e8d6a1 · 5e8d6a1
1 parent 06e7b7a
commit 5e8d6a1
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/java/src/org/openqa/selenium/bidi/module/LogInspector.java b/java/src/org/openqa/selenium/bidi/module/LogInspector.java
@@ -24,6 +24,7 @@
 import java.util.function.Consumer;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.bidi.BiDi;
+import org.openqa.selenium.bidi.Event;
 import org.openqa.selenium.bidi.HasBiDi;
 import org.openqa.selenium.bidi.log.BaseLogEntry;
 import org.openqa.selenium.bidi.log.ConsoleLogEntry;
@@ -36,7 +37,7 @@
 import org.openqa.selenium.internal.Require;
 
 public class LogInspector implements AutoCloseable {
-
+  private final Event<LogEntry> logEntryAddedEvent;
   private final Set<String> browsingContextIds;
 
   private final BiDi bidi;
@@ -59,6 +60,7 @@ public LogInspector(Set<String> browsingContextIds, WebDriver driver) {
 
     this.bidi = ((HasBiDi) driver).getBiDi();
     this.browsingContextIds = browsingContextIds;
+    this.logEntryAddedEvent = Log.entryAdded();
   }
 
   public long onConsoleEntry(Consumer<ConsoleLogEntry> consumer) {
@@ -165,9 +167,9 @@ public void onLog(Consumer<LogEntry> consumer, FilterBy filter) {
 
   private long addLogEntryAddedListener(Consumer<LogEntry> consumer) {
     if (browsingContextIds.isEmpty()) {
-      return this.bidi.addListener(Log.entryAdded(), consumer);
+      return this.bidi.addListener(this.logEntryAddedEvent, consumer);
     } else {
-      return this.bidi.addListener(browsingContextIds, Log.entryAdded(), consumer);
+      return this.bidi.addListener(browsingContextIds, this.logEntryAddedEvent, consumer);
     }
   }