Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final misc. tasks to support data previews (Step 6 of issue #1758) #2523

Merged
merged 12 commits into from
Sep 26, 2024

Commits on Sep 12, 2024

  1. Configuration menu
    Copy the full SHA
    9088638 View commit details
    Browse the repository at this point in the history
  2. Add a download button to the data object view

    - Avoids inflating the download metrics, because the data has already been fetched. The download button simply triggers the download of the data file to the user's computer.
    - Separate out logic for downloading fetched blob in SolrResult so it can be used independently of the DataObjectView
    robyngit committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d9f82b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Speed up rendering large tables in TableEditorView

    - Instead of creating an empty table, then populating it, we now add table cell content as it's created
    - Instead of rendering the table in editing mode then removing editing elements if the table is in view-mode, we now render the table without editing elements if the table is in view-mode
    - Also use document fragment to append table rows to the table element, which is faster than appending each row individually
    
    Issue #1758
    robyngit committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4445212 View commit details
    Browse the repository at this point in the history
  2. Set max num of cells to display in TableEditorView

    - Truncate data and show a message when the table is too large
    
    Issue #1758
    robyngit committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    73fcc25 View commit details
    Browse the repository at this point in the history
  3. Row numbering & parsing fixes for TableEditorView

    - Add row numbers to parsed data rather than assuming the first column is the row number
    - Handle parsing errors more gracefully
    - Don't show empty CSV lines as data rows
    - Allow multiple TableEditorView instances on the same page (Fix issues with dropdowns & unique IDs)
    - Fix issue with adding new rows & cols in editor mode
    
    Issue #1758
    robyngit committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    26e7a58 View commit details
    Browse the repository at this point in the history
  4. Set supported file types & sizes in DataObjectView

    - Show error message when file type is not supported or file size is too large
    
    Issue #1758
    robyngit committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d213d71 View commit details
    Browse the repository at this point in the history
  5. Enable initializing DataObjectView w/ PID

    Can now initialize DataObjectView with a object ID or SolrModel
    
    Issue #1758
    robyngit committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    21a6e20 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cc43393 View commit details
    Browse the repository at this point in the history
  7. Return response from Solr downloadWithCredentials

    Fixes SolrResult test
    Fix a typo
    
    Issue #1758
    robyngit committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9580676 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Configuration menu
    Copy the full SHA
    d2df808 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Configuration menu
    Copy the full SHA
    68ccbcc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    adc3fbf View commit details
    Browse the repository at this point in the history