Render metadig text output as markdown #2506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows markdown to be rendered for any check item on the Metadata Quality view pages. For example, here is a check that has markdown as the output and is rendered as an HTML table:
For the view to render markdown, the "type" property of the "check" in the response must be set to "markdown".
To test these changes, you can override the response in the
parse
method of theQualityReport
collection (i.e. here). Below is a mock response where the fourth check includes markdown as the output. This resposne is the same as the one Jeanette provided in #2394 (comment), except that thetype
has been changed tomarkdown
(something that will happen before the release of the new MDQ suite that includes markdown content)mock response text