Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrape of outer edge of domain so water doesn't pile up. #658

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

aubreyd
Copy link
Collaborator

@aubreyd aubreyd commented Oct 26, 2022

TYPE: bug fix

KEYWORDS: overland flow

SOURCE: Aubrey D., NCAR

DESCRIPTION OF CHANGES:
In the 1D overland flow scheme, the outer edge cells are not properly treated (they are in 2D scheme). This can cause water to pile up on the edges, particularly with limited infiltration (e.g., glacier cells). We do a brute force method here to scrape water above maximum retention depth from these outer cells and capture it in QBDRY. This should someday be updated to match the 2D approach.

ISSUE: The GitHub Issue that this PR addresses. For issue number 123, it would be:

Partially fixes #657

TESTS CONDUCTED:
Tested fix over NWM-Alaska cutout domain and water no longer piles up on edge. Tested NWM-CONUS and confirmed minimal impacts (only along edges), passes ncores, passes perfect restart.

Checklist

Merging the PR depends on following checklist being completed. Add X between each of the square
brackets if they are completed in the PR itself. If a bullet is not relevant to you, please comment
on why below the bullet.

  • Closes issue Overland routing boundary condition along edges not working in 1D scheme #657 (An issue must exist or be created to be closed. The issue describes and documents the problem and general solution, the PR describes the technical details of the solution.)
  • [na] Tests added (unit tests and/or regression/integration tests)
  • Backwards compatible
  • [na] Requires new files? If so, how to generate them.
  • [na] Documentation included
  • [na] Short description in the Development section of NEWS.md

…ed in parallel and lots of prints.

Fixed init issue with boundary adjustment variables and condensed. Changed looping to just cover boundaries. Fixed broadcast call. Passes ncores for small test domain.

Print mods.

Remove prints.
@aubreyd aubreyd requested a review from gochis October 26, 2022 22:15
@aubreyd aubreyd added the bug Something isn't working label Oct 26, 2022
@rcabell
Copy link
Collaborator

rcabell commented Oct 26, 2022

Should edge_adjust be REAL*8, since it's adjusting variables of the same type?

@aubreyd aubreyd force-pushed the overland_edge_fix_new_structure branch from 7f0a229 to 7c04234 Compare November 1, 2022 17:40
@aubreyd
Copy link
Collaborator Author

aubreyd commented Nov 1, 2022

We are keeping real*4 since these are not incremental additions, just batch at end. Removed confusing comment.

@rcabell rcabell merged commit 718ec64 into NCAR:master Nov 1, 2022
rcabell pushed a commit that referenced this pull request Nov 1, 2022
Add scrape of outer edge of domain so water doesn't pile up
scrasmussen pushed a commit to scrasmussen/wrf_hydro_nwm_public that referenced this pull request Aug 4, 2023
Add scrape of outer edge of domain so water doesn't pile up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants