-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce DeprecationWarnings in Testing #582
Conversation
The filter in The filters in
This PR is going to end up leaving two deprecation warnings from The remaining geocat warning is for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little concerned some of these might also be worth looking into a little more deeply and potentially addressing via better handling or tests in geocat-comp.
Sounds good, the interpolate function is a lot of interconnected pieces. Let me write up more about how it is populated |
The interpolation warning is generated by the test
To be interpolated along the values
The test calls Metpy will raise a warning that:
Since the input values max value An easy way to see this is interpolating to 4.5 when the range is to 4:
Where the array position of the max value is out of bounds, so the array appends
When the values are within range, it returns the interpolated values without a nan
|
I think I may be a little confused about what's intended to be in this PR. Is this PR supposed to specifically address deprecation warnings only? Also, since this PR will close #477, I'd like to see more of the warnings discussed in that issue addressed here. |
Co-authored-by: Anissa Zacharias <[email protected]>
Added new issue to address UserWarning in interpolation.py (#593) |
Co-authored-by: Katelyn FitzGerald <[email protected]>
…-comp into deprecation_477
Updated scripts to account for deprecation warnings for using |
PR Summary
Closes #477
PR Checklist
General
closes #XXX
to the PR description where XXX is the number of the issue.docs/release-notes.rst
in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecatedprecommit
. To set up on your local, runpre-commit install
from the top level of the repository. To manually run pre-commits, usepre-commit run --all-files
and re-add any changed files before committing again and pushing.