Update testing for release #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…into feature/testing_for_release
… feature/testing_for_release
…testing_for_release
…testing_for_release
grantfirl
reviewed
May 22, 2024
| @@ -150,6 +150,7 @@ jobs: | |||
| cd ${SCM_ROOT} | |||
| ./contrib/get_all_static_data.sh | |||
| ./contrib/get_thompson_tables.sh | |||
| ./contrib/get_aerosol_climo.sh | |||
There was a problem hiding this comment.
This is going to (potentially) slow down CI a lot since the files are big. Any way to stash this data for future use?
There was a problem hiding this comment.
I was worried that this was going to bring this whole thing crashing down, but to my surprise it is faster to download this data on the GitHub servers than on Hera. It only took ~2min., but that's more than the ~15sec before.
There may be slick ways to stash this, I just don't know any.
grantfirl
reviewed
May 22, 2024
grantfirl
reviewed
May 22, 2024
grantfirl
approved these changes
May 22, 2024
|
@grantfirl I addressed your concerns. Now the script only creates plots when there are differences, and the comparison/plotting scripts are usable outside of the RT/CI context (I used them offline for faster debugging of the CI plots) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes/updates to the SCM RT CI for the CCPP V7 release. Includes the following:
This PR contains changes from #467 and #474.