Skip to content

Commit

Permalink
Apparently GitHub secrets are not passed when PRs come in from forks.…
Browse files Browse the repository at this point in the history
… This job shouldn't need those credentials anyway now that I separated out the push step, so removing the Login step should fix this
  • Loading branch information
mkavulich committed May 1, 2024
1 parent 8705d32 commit 0178503
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/ci_test_docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@ jobs:
uses: docker/setup-qemu-action@v3
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Login to Docker Hub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Build and export test tag
uses: docker/build-push-action@v5
with:
Expand Down

0 comments on commit 0178503

Please sign in to comment.