Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GNU -Wall Warning Reduction, Part 1 #1105

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

GNU -Wall Warning Reduction, Part 1 #1105

wants to merge 7 commits into from

Conversation

scrasmussen
Copy link
Member

@scrasmussen scrasmussen commented Dec 12, 2024 •
edited
Loading

DESCRIPTION OF CHANGES: This is subset of commits from PR #1049 and PR #1048. I've combined them into one PR so I only have to do one that targets ufs-community:ufs/dev for now.

The warning report was made using create_warning_report.sh from the warning-report branch of my SCM fork. Users will need to edit scm/src/CMakeLists.txtso GNU's CMAKE_Fortran_FLAGS_DEBUG has -Wall at the end to get all the warnings.

NOTE: this PR removes 219 warnings. Ampersand and tab warnings will be reduced with SCM PR#425

$ VERBOSE=1 make &> out.txt
$ bash ../count.sh out.txt
image

ISSUES: related to Issues #495

This was referenced Dec 12, 2024
Closed
Closed
tanyasmirnova
tanyasmirnova approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@tanyasmirnova tanyasmirnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are only formatting changes in RUC LSM.

climbfuji
climbfuji approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all these changes. Good to see the trailing whitespaces and all the tabs gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanyasmirnova tanyasmirnova tanyasmirnova approved these changes

@climbfuji climbfuji climbfuji approved these changes

@wd20xw wd20xw Awaiting requested review from wd20xw wd20xw is a code owner

@grantfirl grantfirl Awaiting requested review from grantfirl grantfirl is a code owner

@rhaesung rhaesung Awaiting requested review from rhaesung rhaesung is a code owner

@Qingfu-Liu Qingfu-Liu Awaiting requested review from Qingfu-Liu Qingfu-Liu is a code owner

@dustinswales dustinswales Awaiting requested review from dustinswales dustinswales is a code owner

@barlage barlage Awaiting requested review from barlage barlage is a code owner

@cenlinhe cenlinhe Awaiting requested review from cenlinhe cenlinhe is a code owner

@HelinWei-NOAA HelinWei-NOAA Awaiting requested review from HelinWei-NOAA HelinWei-NOAA is a code owner

@SamuelTrahanNOAA SamuelTrahanNOAA Awaiting requested review from SamuelTrahanNOAA SamuelTrahanNOAA is a code owner

@joeolson42 joeolson42 Awaiting requested review from joeolson42 joeolson42 is a code owner

@RuiyuSun RuiyuSun Awaiting requested review from RuiyuSun RuiyuSun is a code owner

@mdtoyNOAA mdtoyNOAA Awaiting requested review from mdtoyNOAA mdtoyNOAA is a code owner

@haiqinli haiqinli Awaiting requested review from haiqinli haiqinli is a code owner

@mzhangw mzhangw Awaiting requested review from mzhangw mzhangw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scrasmussen @climbfuji @tanyasmirnova