Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in physics/GWD/ugwp_driver_v0.F to prevent using uninitialized Bnv2 array in line 350 #1104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion physics/GWD/ugwp_driver_v0.F
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,9 @@ SUBROUTINE GWDPS_V0(IM, km, imx, do_tofd,
BVF2 = grav2 * RDZ * (VTK(I,K+1)-VTK(I,K))
& / (VTK(I,K+1)+VTK(I,K))
bnv2(i,k+1) = max( BVF2, bnv2min )
RI_N(I,K+1) = Bnv2(i,k)/SHR2 ! Richardson number consistent with BNV2
! https://github.com/NCAR/ccpp-physics/issues/1103
!RI_N(I,K+1) = Bnv2(i,k)/SHR2 ! Richardson number consistent with BNV2
RI_N(I,K+1) = Bnv2(i,max(k,2))/SHR2 ! Richardson number consistent with BNV2
!
! add here computation for Ktur and OGW-dissipation fro VE-GFS
!
Expand Down