-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Three patches for time series generation #218
Conversation
1. Added "case" argument to env_workflow.get_job_specs() 2. explicitly ignored last two arguments returned from env_mach_specific.get_mpirun() -- shouldn't be necessary, but I was seeing "ValueError: too many values to unpack" and the error went away with the additional _s 3. Remove indexing from options.debug in tseries_generator, since parser.add_argument() explicitly casts it as int; avoids "TypeError: 'int' object has no attribute '__getitem__'"
@@ -37,7 +37,7 @@ def _main_func(description): | |||
"queue" : case.get_value("JOB_QUEUE", subgroup=job), | |||
"unit_testing" : False | |||
} | |||
executable, mpi_arg_list = env_mach_specific.get_mpirun(case, mpi_attribs, job, overrides=overrides) | |||
executable, mpi_arg_list, _, _ = env_mach_specific.get_mpirun(case, mpi_attribs, job, overrides=overrides) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand why this change was necessary. Maybe something weird from python 2.7?
I needed to make these changes to run a case from |
Fixes #217 (I don't have permission to link the issue to this PR) |
@mnlevy1981 - I'm going to wait on merging this PR as it's not clear what direction the |
Regarding the indexing of the debug parameter, I agree that this should be removed. However, the proposed solution will lead to DEBUG statements when '0' is specified, since the result is stored in a list I propose this alternative:
this will work as expected in all cases, and even works when |
@mnlevy1981 I know this is old, but could you resolve the conflicts here? |
case
argument toenv_workflow.get_job_specs()
env_mach_specific.get_mpirun()
-- shouldn't be necessary, but I was seeingValueError: too many values to unpack
and the error went away with theadditional
_
soptions.debug
intseries_generator
, sinceparser.add_argument()
explicitly casts it as int; avoidsTypeError: 'int' object has no attribute '__getitem__'