-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Reflectance concepts #329
Open
jianyangli
wants to merge
7
commits into
NASA-Planetary-Science:main
Choose a base branch
from
jianyangli:update_reflectance_size_conversion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP: Reflectance concepts #329
jianyangli
wants to merge
7
commits into
NASA-Planetary-Science:main
from
jianyangli:update_reflectance_size_conversion
Commits on May 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f35e481 - Browse repository at this point
Copy the full SHA f35e481View commit details
Commits on May 2, 2022
-
expand equivalencies for disk-integrated albedo
* Rename `reflectance` to `dimensionless_albedo` * Use disk-integrated albedo (product of geometric albedo and disk-integrated phase function) rather than disk-average bidirectional reflectance * Add conversion between albedo and cross-section with a given total flux/magnitude * Updated docstrings and doctests * Add optional parameters `rh` and `delta` for future implementation.
Configuration menu - View commit details
-
Copy full SHA for 7a6cf74 - Browse repository at this point
Copy the full SHA 7a6cf74View commit details -
* Update test data with the new albedo definition (albedo = reflectance * pi) * Add tests for `albedo_unit` * Add tests for convertion between albedo and size * Expand tests to cover the conversion in both directions for all cases * Replace np.isclose and np.allclose by u.isclose or u.allclose
Configuration menu - View commit details
-
Copy full SHA for 2bf739e - Browse repository at this point
Copy the full SHA 2bf739eView commit details
Commits on May 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 92e902f - Browse repository at this point
Copy the full SHA 92e902fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 301092e - Browse repository at this point
Copy the full SHA 301092eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 666ce60 - Browse repository at this point
Copy the full SHA 666ce60View commit details
Commits on Jun 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ebf192b - Browse repository at this point
Copy the full SHA ebf192bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.