Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Reflectance concepts #329

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Commits on May 1, 2022

  1. add albedo unit

    jianyangli committed May 1, 2022
    Configuration menu
    Copy the full SHA
    f35e481 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. expand equivalencies for disk-integrated albedo

    * Rename `reflectance` to `dimensionless_albedo`
    * Use disk-integrated albedo (product of geometric albedo and disk-integrated phase function) rather than disk-average bidirectional reflectance
    * Add conversion between albedo and cross-section with a given total flux/magnitude
    * Updated docstrings and doctests
    * Add optional parameters `rh` and `delta` for future implementation.
    jianyangli committed May 2, 2022
    Configuration menu
    Copy the full SHA
    7a6cf74 View commit details
    Browse the repository at this point in the history
  2. update tests for sbpy.unit

    * Update test data with the new albedo definition (albedo = reflectance * pi)
    * Add tests for `albedo_unit`
    * Add tests for convertion between albedo and size
    * Expand tests to cover the conversion in both directions for all cases
    * Replace np.isclose and np.allclose by u.isclose or u.allclose
    jianyangli committed May 2, 2022
    Configuration menu
    Copy the full SHA
    2bf739e View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. fix photometry module

    Including all tests and remote tests.
    jianyangli committed May 3, 2022
    Configuration menu
    Copy the full SHA
    92e902f View commit details
    Browse the repository at this point in the history
  2. PEP8 fixes

    jianyangli committed May 3, 2022
    Configuration menu
    Copy the full SHA
    301092e View commit details
    Browse the repository at this point in the history
  3. update documents

    jianyangli committed May 3, 2022
    Configuration menu
    Copy the full SHA
    666ce60 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Configuration menu
    Copy the full SHA
    ebf192b View commit details
    Browse the repository at this point in the history