Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NUOPC Cap Improvements #1645

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

NUOPC Cap Improvements #1645

wants to merge 2 commits into from

Conversation

danrosen25
Copy link
Contributor

Description

This pull requests maintains the cap by cleaning up the code for better maintainability and enhancements. Enhancements were made to the documentation, the import and export state initialization, and the import state checking

Resolves #1644

Testcase

Uses NASA Land Coupler for testing
https://github.com/esmf-org/NASA-Land-Coupler/tree/feature/lisf_upgrade

bit-for-bit results for coupled tuolumne cases

SUCCESS: coupled_tuolumne.ens020.noahmp_v4.0.1_da.nldas2 LIS_HIST_201403020000.d01.nc
SUCCESS: coupled_tuolumne.ens020.noahmp_v4.0.1_da.nldas2 LIS_HIST_201403030000.d01.nc
SUCCESS: coupled_tuolumne.noahmp.nldas2 LIS_HIST_201510020000.d01.nc
SUCCESS: coupled_tuolumne.noahmp.nldas2 LIS_HIST_201510030000.d01.nc

@danrosen25
Cleanup NUOPC Cap - remove comments
33395fe
@danrosen25
NUOPC Cap Improvements
476d99d 
* add README file and guides
* update documentation using Doxygen
* add gnu/intel debug options for BUILD_TYPE=DEBUG
* update missing field value to 9.99e20
* add initialization options for import and export states
* add missing value check (disable with MISSINGVAL_SKPCPY or MISSINGVAL_IGNORE)
* call lisfinalize during cap finalize
* move configuration options to LIS_NUOPC_Flags.F90
@danrosen25
Copy link
Contributor Author

danrosen25 commented Nov 26, 2024 •
edited
Loading

@jvgeiger @dmocko @emkemp
Hi all,
I'm submitting updates to the NUOPC coupling interface (NUOPC Cap). It's going to come in a few separate different pull requests to isolate the changes. This first change is NUOPC cap only changes. I ran testing in a coupled configuration but it will need some offline regression tests.

@danrosen25
Copy link
Contributor Author

@sujayvkumar
I'm including Sujay in this conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup NUOPC Cap for LIS
1 participant
@danrosen25