Feature/AquaCropv7.2 integration

[lbusschaert]

Description

This PR introduces the implementation of a crop model (AquaCropv7.2) in LIS, along with the LDT parameter processing. The implementation was done within the KU Leuven team of Prof. Gabriëlle De Lannoy, mainly by Michel Bechtold and myself.
Research has been done with a preliminary version of AquaCropv7.0 in LIS:

• https://agupubs.onlinelibrary.wiley.com/doi/full/10.1029/2024JG008231
• https://papers.ssrn.com/sol3/papers.cfm?abstract_id=4974019

The objective was now to develop a final working version in LIS.

I was visiting the NASA-LIS team in early 2024 and prepared this implementation in collaboration with Sujay Kumar and David Mocko. The implementation is now finalized and has been carefully tested and compared to AquaCrop reference output.

AquaCropv7.2 (ac72) is now part of the surfacemodels/land/. The implementation is documented in
LIS_AC_documentation.pdf

We acknowledge that this is a large PR and we greatly appreciate the time you spend on it. Do not hesitate to contact me in case of any questions ([email protected]).

Testcase

Test cases for LDT and LIS have been added under the ldt/testcases and lis/testcases folders. The data for the test cases are stored in a Zenodo repository organized in the requested format: https://zenodo.org/records/14035685

[dmocko]

Hi @lbusschaert

Congratulations to you and your team for submitting this PR to get AquaCrop fully merged into the LIS code!

I did a quick review, and I have a few initial requests:

1. Can you please add all of the new config entries, and a brief explanation on them, into the ldt/configs/ldt.config.adoc and lis/configs/lis.config.adoc files?

For example, "AquaCrop reference year for climatology:" for the ldt.config.adoc file, and "AquaCrop.7.2 model timestep:" for the lis.config.adoc file.

2. Similarly, can you please add the new possible LIS outputs into the lis/configs/MODEL_OUTPUT_LIST.TBL.adoc file?

I see that you have them in your testcase, but it would be great to include them in the primary model output doc.

3. You checked in an empty user.cfg file, but we actually prefer to not have any user.cfg file in our main branch. Can you please remove this file from the commits?

Thank you.

[lbusschaert]

Hi @lbusschaert

Congratulations to you and your team for submitting this PR to get AquaCrop fully merged into the LIS code!

I did a quick review, and I have a few initial requests:

1. Can you please add all of the new config entries, and a brief explanation on them, into the ldt/configs/ldt.config.adoc and lis/configs/lis.config.adoc files?

For example, "AquaCrop reference year for climatology:" for the ldt.config.adoc file, and "AquaCrop.7.2 model timestep:" for the lis.config.adoc file.

2. Similarly, can you please add the new possible LIS outputs into the lis/configs/MODEL_OUTPUT_LIST.TBL.adoc file?

I see that you have them in your testcase, but it would be great to include them in the primary model output doc.

3. You checked in an empty user.cfg file, but we actually prefer to not have any user.cfg file in our main branch. Can you please remove this file from the commits?

Thank you.

Hi @dmocko,

Thank you for noticing these points. They should be addressed now.

[dmocko]

Both LDT and LIS compiled on the Discover Milan nodes.

Will next work on running the testcase.