-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/generic vector ingests #220
Conversation
dags/veda_data_pipeline/veda_process_generic_vector_pipeline.py
Outdated
Show resolved
Hide resolved
dags/veda_data_pipeline/veda_process_generic_vector_pipeline.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @amarouane-ABDELHAK , @smohiudd , @ranchodeluxe , you guys ok with merging this?
I just added some general comments on documentation. The way the original EIS vector dag is labelled it's hard to know the difference between that and the generic. So in the docs would be good to be specific that the |
Summary: Refactor code to support vector data ingest
Addresses Issue
Changes
eis
-related functionalies.EXTERNAL_ROLE_ARN
passed to the vector ingest ECSPR Checklist