Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new check for OPeNDAP for granules #305

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Add new check for OPeNDAP for granules #305

wants to merge 3 commits into from

Conversation

binni979
Copy link
Contributor

@binni979 binni979 commented Nov 4, 2024

Overview
This pull request introduces a new check to verify the presence of OPeNDAP links in granule URL fields. The goal is to ensure that OPeNDAP links are included in the URL fields of granule metadata.
New Check Details
Check: Verify if OPeNDAP links are present in specified URL fields.
Fields:
Granule/OnlineResources/OnlineResource/URL (echo-g)
RelatedURLs/URL (umm-g)

Check Logic
The check inspects the specified URL fields for the presence of "opendap" in the URL.
If "opendap" is not found, a warning is generated, recommending the addition of an OPeNDAP link for this granule.

Implementation Steps
Added a new function, opendap_link_check, to perform the URL validation.
Added rule_mapping.json to include this new check.
Added checks.json to enable the OPeNDAP link check.
Added check_message.json to define warning messages for missing OPeNDAP links.

Testing
Tested Granules:
Granules that have opendap in URL, No opendap error was reported.

  1. echo-g: G1463204472-LAADS
  2. echo-g: G1479429385-LAADS
  3. echo-g: G1689034590-OB_DAAC
  4. umm-g: G2271018132-POCLOUD
  5. umm-g: G2081781961-POCLOUD

umm-g: G1997478801-LARC_ASDC (Does not contain "opendap" in URL or have URL type "OPENDAP DATA") – Error: Warning generated to recommend adding an OPeNDAP link.

Screenshot 2024-11-04 at 3 38 50 PM

@binni979 binni979 self-assigned this Nov 4, 2024
@binni979 binni979 changed the title Add new check for OPeNDAP for for granules Add new check for OPeNDAP for granules Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant