Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit setting of owner in view creation/update #766

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Remove explicit setting of owner in view creation/update #766

merged 1 commit into from
Jul 10, 2023

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Jul 10, 2023

This fixes an issue where view creation fails when the user is not admin due to the owner field being supplied in the payload.

@duranb duranb added the fix A bug fix label Jul 10, 2023
@duranb duranb requested a review from a team as a code owner July 10, 2023 16:00
@duranb duranb self-assigned this Jul 10, 2023
@duranb duranb temporarily deployed to test-workflow July 10, 2023 16:00 — with GitHub Actions Inactive
camargo
camargo approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@camargo camargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!!

@duranb duranb merged commit 18a229e into develop Jul 10, 2023
4 checks passed
@duranb duranb deleted the fix/remove-explicit-view-owner branch July 10, 2023 16:10
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@duranb
Remove explicit setting of owner in view creation/update (#766)
c32e5b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camargo camargo camargo approved these changes

@jeffpamer jeffpamer Awaiting requested review from jeffpamer jeffpamer is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@AaronPlave AaronPlave Awaiting requested review from AaronPlave AaronPlave is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees

@duranb duranb

Labels
fix A bug fix
Projects
Aerie
Archived in project
Milestone
FY23 Q3 - User Roles and Permissions
Development

Successfully merging this pull request may close these issues.
2 participants
@duranb @camargo