Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission checks to Command Dictionaries page #749

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

jeffpamer
Copy link
Contributor

Resolves #692

This one seems pretty straightforward: adds checks to the command dictionaries page to ensure user has the required permissions before uploading and/or deleting dictionaries.

To test

  • Open command dictionaries page as Admin, confirm you are able to upload new and delete existing command dictionaries
  • Switch role to User and confirm you are no longer able to upload or delete.

2023-06-28 17 03 13

@jeffpamer jeffpamer added the feature New feature or request label Jun 29, 2023
@jeffpamer jeffpamer requested a review from a team as a code owner June 29, 2023 00:07
@jeffpamer jeffpamer self-assigned this Jun 29, 2023
@jeffpamer jeffpamer deployed to test-workflow June 29, 2023 00:07 — with GitHub Actions Active
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻 just a little formatting comment but otherwise LGTM!

src/routes/dictionaries/+page.svelte Outdated Show resolved Hide resolved
@jeffpamer jeffpamer force-pushed the feature/command-dictionary-permissions branch from bf11a46 to 4a7a47f Compare June 29, 2023 18:19
@jeffpamer jeffpamer temporarily deployed to test-workflow June 29, 2023 18:19 — with GitHub Actions Inactive
@jeffpamer jeffpamer merged commit 7f85de3 into develop Jun 29, 2023
4 checks passed
@jeffpamer jeffpamer deleted the feature/command-dictionary-permissions branch June 29, 2023 18:40
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
* Add permission checks to Command Dictionaries page

* fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add permissions to Command Dictionaries page
2 participants