Add support for controls #783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example coming
Example setup via standard r3f [installation instructions](https://r3f.docs.pmnd.rs/getting-started/installation)doc with vite bundler. Removed glb test files which are heavy, prefer CDN served Suzanne. ```bash # Create app npm create vite r3f-3dtilesrenderer # Install dependencies cd r3f-3dtilesrenderer npm install three @react-three/fiber @react-three/drei # Start development server npm run dev ```
- Add leva for options control - add proj4 computeCrsTransform for correct vertical - rename component to DemoTiles
…ug property Depending on the renderer used, different props have to be passed: - `props.type === TilesRendererType.Standard`: requires `props.path` - `props.type === TilesRendererType.Google`: requires `props.googleApiKey` - `props.type === TilesRendererType.CesiumIon`: requires `props.ionAssetId & props.ionAccessToken`
WIP works for standard TilesRenderer, now need to test it for CesiumIon and Google
Extracted some code out of the r3d component, to be defined at application level Now works for google, ion, standard with custom matrix transform. Still need to try to extract the matrixTransform outside of the component as well
* Wrap an r3f component for standard TilesRenderer Example coming * Create example/r3f-3dtilesrenderer with vite Example setup via standard r3f [installation instructions](https://r3f.docs.pmnd.rs/getting-started/installation)doc with vite bundler. Removed glb test files which are heavy, prefer CDN served Suzanne. ```bash # Create app npm create vite r3f-3dtilesrenderer # Install dependencies cd r3f-3dtilesrenderer npm install three @react-three/fiber @react-three/drei # Start development server npm run dev ``` * Quickfixes - Add leva for options control - add proj4 computeCrsTransform for correct vertical - rename component to DemoTiles * Add Google and Cesium Ion in addition to Standard Renderers, with debug property Depending on the renderer used, different props have to be passed: - `props.type === TilesRendererType.Standard`: requires `props.path` - `props.type === TilesRendererType.Google`: requires `props.googleApiKey` - `props.type === TilesRendererType.CesiumIon`: requires `props.ionAssetId & props.ionAccessToken` * WIP MatrixTransform works for standard tileset WIP works for standard TilesRenderer, now need to test it for CesiumIon and Google * Works for google, ion, standard renderer Extracted some code out of the r3d component, to be defined at application level Now works for google, ion, standard with custom matrix transform. Still need to try to extract the matrixTransform outside of the component as well
# Conflicts: # example/r3f-3dtilesrenderer/src/App.jsx
* Add support for the tile root frame transformations * fixes * Add east north up frame component * Update package.json * Add children to new root objects * Fixed tile coordinate frames
* Add overlay component * Remove unused imports * Fix dom overlay * Fixes to dom overlay * Add support for ion attributions * Add attributions component * Rename component * Adjust use of pointer events all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #770