Show hide feature #136
Merged
Show hide feature #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
June 2, 2020 11:48
…mplemented show()/hide() methods in UIContainer. Implemented a new class UILayeredUpdates inheriting from pygame.sprite. LayeredUpdates that omits UIElements with is_visible flag == False when drawing. Made UIManager use the new UILayeredUpdates class instead of pygame.sprite. LayeredUpdates. Changed method process_events() in UIManager to ignore UIElements with is_visible flag == False when checking MOUSEBUTTONDOWN events. Changed method update() to ignore UIElements with is_visible flag == False when checking hover events. Added tests for show / hide behaviour of UIElements and UIContainers.
… UIButton and UIImage.
…ner. Updated UIHorizontalScrollBar.
…UIToolTip and various windows that show()/hide() is unsupported for now. Merged new changes from upstream/master.
…ill transition to normal state. Started filling in the comments and docstrings.
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
- Coverage 95.12% 94.29% -0.84%
==========================================
Files 56 56
Lines 7426 7570 +144
==========================================
+ Hits 7064 7138 +74
- Misses 362 432 +70
Continue to review full report at Codecov.
|
|
Amazing! Huge thanks for the giant contribution. I'll merge this into master and see about adding a button somewhere in the general UI example project that toggles show and hide on and off. |
|
You're welcome, I hope everything works correctly and that it will be useful. I'd like to implement a couple more things:
So expect another pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'show()' / 'hide()' methods and 'visible' argument of init() has been implemented for all UIElements and UIContainer.
I also implemented several tests and wrote some docstrings.