Remove osc-min dependency #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #115 Remove the `osc-min` dependency and implement `toBuffer` and `fromBuffer` functions according to the OSC specification. * **package.json** - Remove the `osc-min` dependency - Add a package import named `#osc` pointing to `lib/internal/osc.mjs` * **lib/internal/osc.mjs** - Implement the `toBuffer` function - Implement the `fromBuffer` function * **lib/Client.mjs** - Remove the import of `osc-min` - Import `toBuffer` from `#osc` - Update the `send` method to use `toBuffer` from `#osc` * **lib/Server.mjs** - Remove the import of `#decode` - Import `fromBuffer` from `#osc` - Update the `_sock.on('message')` handler to use `fromBuffer` from `#osc` * **test/test-osc.mjs** - Add tests for the `toBuffer` function - Add tests for the `fromBuffer` function * **Remove files** - `lib/internal/decode.mjs` - `test/test-decode.mjs` --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/MylesBorins/node-osc/issues/115?shareId=XXXX-XXXX-XXXX-XXXX).
MylesBorins
commented
Oct 8, 2024
MylesBorins
commented
Oct 8, 2024
lib/internal/osc.mjs
Outdated
| @@ -0,0 +1,226 @@ | |||
| import { Buffer } from 'node:buffer'; | |||
|
|
|||
| function toBuffer(object, strict = false) { | |||
There was a problem hiding this comment.
Suggested change
| function toBuffer(object, strict = false) { | |
| function toBuffer(object) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115
Remove the
osc-mindependency and implementtoBufferandfromBufferfunctions according to the OSC specification.package.json
osc-mindependency#oscpointing tolib/internal/osc.mjslib/internal/osc.mjs
toBufferfunctionfromBufferfunctionlib/Client.mjs
osc-mintoBufferfrom#oscsendmethod to usetoBufferfrom#osclib/Server.mjs
#decodefromBufferfrom#osc_sock.on('message')handler to usefromBufferfrom#osctest/test-osc.mjs
toBufferfunctionfromBufferfunctionRemove files
lib/internal/decode.mjstest/test-decode.mjsFor more details, open the Copilot Workspace session.