Correct handling of "today" to support foreign languages #139
Conversation
"today" in __populate_report should be passed with English (lang='en'), otherwise it is defined as None. The same applies to "today" in ___populate_current, where self.__extract_datetime should be used with English as language.
|
Hi @junivex, Thank you for helping with the Mycroft project! We welcome everyone into the community and greatly appreciate your help as we work to build an AI for Everyone. To protect yourself, the project, and users of Mycroft technologies we require a Contributor Licensing Agreement (CLA) before accepting any code contribution. This agreement makes it crystal clear that along with your code you are offering a license to use it within the confines of this project. You retain ownership of the code, this is just a license. You will also be added to our list of excellent human beings! Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank you! |
|
Hey @krisgesling, thanks for the remark. I'm happy to contribute, and readily signed the CLA. |
|
Hey, I just tried to send out the CLA but the email address we got bounced. Can you email me at [email protected] so I can be sure we have the spelling correct. Thanks. |
|
CLA received and working great, thanks again. |
Resolves Nonetype Error that occurs for other languages than English (#138).
"today" in __populate_report should be passed with English language (lang='en'), otherwise it is defined as None, if another language is used as default.
The same applies to "today" in ___populate_current, where self.__extract_datetime should be used with English as language.