Ensure long form "50 percent" is registered as Adapt entity #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different STT engines will return text in different formats. This ensures text returned in the long form "50 percent" is still captured as an Adapt entity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Different STT engines will return text in different formats. This ensures text returned in the long form "50 percent" is still registered as an Adapt entity. These were being captured most of the time, but could be over matched by other intents like brightness even with "volume" included in the utterance as the "Percent" entity wasn't present.
Thanks to @Olzeke51 and @sgee_ who reported this in Mycroft Chat.
Type of PR
Testing
VK tests updated.