-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove docs encouraging Skill config via mycroft.conf #2936
Conversation
Voight Kampff Integration Test Succeeded (Results) |
Codecov Report
@@ Coverage Diff @@
## dev #2936 +/- ##
==========================================
- Coverage 52.62% 52.61% -0.01%
==========================================
Files 123 123
Lines 11016 11016
==========================================
- Hits 5797 5796 -1
- Misses 5219 5220 +1
Continue to review full report at Codecov.
|
|
||
- [STT API, Google STT, Google Cloud Speech](http://www.chromium.org/developers/how-tos/api-keys) | ||
- [A range of STT services](https://mycroft-ai.gitbook.io/docs/using-mycroft-ai/customizations/stt-engine) are available for use with Mycroft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the intended indentation level? It looks a bit weird in the preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it was. It does look a little weird, but it's part of the point above...
I'm just going to go with it for the moment.
The whole README could probably do with a refresh...
Thanks for the eagle eyes though :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good IMO, there was an indentation I wasn't sure if it was intended or not. Assuming it was I approve
Makes sense to me, the individual key setup is better documented in the individual skills. In here it would have a tendency to get outdated, another advantage is that the readme changes become part of the individual skill git history |
Description
Removes an outdated section of the main README that encouraged the use of mycroft.conf for Skill configuration.
The example used was also outdated as you cannot currently configure the mycroft-weather Skill to use a local API key.
Raised in MycroftAI/skill-weather#170
How to test
Markdown only
Contributor license agreement signed?