Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some missing resource files in spanish #22

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

added some missing resource files in spanish #22

wants to merge 8 commits into from

Conversation

adocampo
Copy link
Contributor

I'm facing a problem in this code:

    "date_time_format": {
    "date_time": "{formatted_date} at {formatted_time}"
  },

In spanish, when we said 1am or 1pm (01h or 13h) we say la una, the other 23 hours we say las X (e.g: las dos, las diez, etc)... how could I translate this?
I could use 24h format, and let it as

    "date_time_format": {
    "date_time": "{formatted_date} a las {formatted_time}"
  },

but this would leave the case of 01h, which needs to be {formatted_date} a la {formatted_time}

@JarbasAl
Copy link
Collaborator

i a having the same problem, for now i just left it in the plural form

i plan on doing some refactor to that class, in particular i want to make it use the pronounce_number methods, take a look at the portuguese PR for an early version

we can make another PR later on handling these edge cases

@JarbasAl JarbasAl added the es relates to spanish language label Sep 12, 2019
@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Nov 3, 2019
ChanceNCounter pushed a commit to ChanceNCounter/lingua-franca that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) es relates to spanish language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants