More it-it long form number tests #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisgesling
added
CLA: Yes
|
can this please use scientific notation? counting zeros to validate long/short scale is very error prone... with scientific notation we just look at the exponent and can immediately judge if things are working like they should. Since these tests are all about the number of zeros i don't feel too bad requesting such a (code wise) inconsequential thing |
Stypox
reviewed
Feb 2, 2021
fix typo per @Stypox Co-authored-by: Stypox <[email protected]>
|
Bump: change to sci |
krisgesling
force-pushed
the
feature/it-large-num
branch
from
5ac1293
to
77281cd
Compare
krisgesling
force-pushed
the
feature/it-large-num
branch
from
77281cd
to
a1df117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new pronounce_number tests using the default params which sounds like it should default to long form.
Note: This does not address failing tests.