Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(segmented-control): fix disabled state for segmented-control items #832

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

gavin-everett-genesys
Copy link
Collaborator

fix disabled state from segmented-control items

✅ Closes: COMUI-3369

Copy link

Copy link
Collaborator

@daragh-king-genesys daragh-king-genesys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tried this but it might be easier to do this in the parent like selected

  @Watch('disabled')
  watchDisabled(): void {
    this.items.forEach(switchItem => {
      forceUpdate(switchItem)
    });
  }

fix disabled state from segmented-control items

✅ Closes: COMUI-3369
@gavin-everett-genesys
Copy link
Collaborator Author

I have not tried this but it might be easier to do this in the parent like selected

  @Watch('disabled')
  watchDisabled(): void {
    this.items.forEach(switchItem => {
      forceUpdate(switchItem)
    });
  }

Yeah that works much better 🚀

@gavin-everett-genesys gavin-everett-genesys merged commit 6a48529 into main Jan 14, 2025
3 checks passed
@gavin-everett-genesys gavin-everett-genesys deleted the feature/COMUI-3369 branch January 14, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants