fix(time-picker): Added validation input check (WIP) #660
Conversation
✅ Closes: COMUI-825
|
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-825 |
github-actions
bot
requested review from
daragh-king-genesys and
thomas-c-dillon
| @@ -1,5 +1,8 @@ | |||
| @use '~genesys-spark/dist/scss/mixins.scss'; | |||
| @use '~genesys-spark/dist/scss/focus.scss'; | |||
| @use '../gux-form-field/functional-components/gux-form-field-error/gux-form-field-error.scss'; | |||
There was a problem hiding this comment.
My intuition is that the time-picker isn't a form-field component so technically maybe we should move the css in gux-form-field-error.scss to a separate file that can be reused throughout the app for non form-field components, but let me know what you all think.
| @@ -78,6 +83,26 @@ export class GuxTimePicker { | |||
| @Listen('blur') | |||
| onBlur() { | |||
| if (this.valueLastChange !== this.value) { | |||
| // Format input time to match format found in the popup time list (e.g. "01:30" -> "1:30", "00:30" -> "12:30", etc) | |||
| const split = this.value.split(':'); | |||
There was a problem hiding this comment.
This logic here needs some reworking. I'm wondering if we need to handle different time formats from the user or will the user have to input with a specific time format all the time? For instance could the user input "01:30" and also "13:30" and also "1:30"?
| @@ -78,6 +83,26 @@ export class GuxTimePicker { | |||
| @Listen('blur') | |||
| onBlur() { | |||
| if (this.valueLastChange !== this.value) { | |||
| // Format input time to match format found in the popup time list (e.g. "01:30" -> "1:30", "00:30" -> "12:30", etc) | |||
There was a problem hiding this comment.
Do you all think it makes sense to trigger input validation on blur or instead on input value change? I was worried triggering validation on input value change would be more intrusive than on blur.
✅ Closes: COMUI-825
✅ Closes: COMUI-825
WIP